Turned-off etcd listening on public ports as potentially insecure. #35192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wojtek-t
reviewed
Oct 20, 2016
| @@ -37,7 +37,7 @@ | |||
| "command": [ | |||
| "/bin/sh", | |||
| "-c", | |||
| "if [ -e /usr/local/bin/migrate-if-needed.sh ]; then /usr/local/bin/migrate-if-needed.sh; fi; /usr/local/bin/etcd --name etcd-{{ hostname }} --listen-peer-urls http://{{ hostname }}:{{ server_port }} --initial-advertise-peer-urls http://{{ hostname }}:{{ server_port }} --advertise-client-urls http://127.0.0.1:{{ port }} --listen-client-urls http://127.0.0.1:{{ port }} --data-dir /var/etcd/data{{ suffix }} --initial-cluster-state {{ cluster_state }} --initial-cluster {{ etcd_cluster }} 1>>/var/log/etcd{{ suffix }}.log 2>&1" | |||
| "if [ -e /usr/local/bin/migrate-if-needed.sh ]; then /usr/local/bin/migrate-if-needed.sh; fi; /usr/local/bin/etcd --listen-peer-urls http://127.0.0.1:{{ server_port }} --advertise-client-urls http://127.0.0.1:{{ port }} --listen-client-urls http://127.0.0.1:{{ port }} --data-dir /var/etcd/data{{ suffix }} 1>>/var/log/etcd{{ suffix }}.log 2>&1" | |||
There was a problem hiding this comment.
Can you leave "--name" flag? This is useful also for etcd3 and I don't think it breaks anything itself.
k8s-github-robot
added
do-not-merge
Turn-off etcd listining on public ports as potentially insecure. Removed experimental support for master replication.
jszczepkowski
force-pushed
the
ha-port-fix-14
branch
from
128ab5e
to
939a108
Compare
|
PTAL |
jszczepkowski
added
release-note
fgrzadkowski
added
the
lgtm
|
@jessfraz This PR is needed to fix vulnerability in 1.4 where we started listening on public network interface without using SSL. |
|
lgtm |
jessfraz
added
cherrypick-candidate
cherry-pick-approved
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
Jenkins GCE etcd3 e2e failed for commit 939a108. Full PR test history. The magic incantation to run this job again is |
|
Commit found in the "release-1.4" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked. |
|
Part of kubernetes/enhancements#48 |
shyamjvs
pushed a commit
to shyamjvs/kubernetes
that referenced
this pull request
Dec 1, 2016
Automatic merge from submit-queue Turned-off etcd listening on public ports as potentially insecure. ```release-note Turned-off etcd listening on public ports as potentially insecure. Removed experimental support for master replication. ``` Turned-off etcd listening on public ports as potentially insecure. Removed experimental support for master replication.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turned-off etcd listening on public ports as potentially insecure. Removed
experimental support for master replication.
This change is