Migrate from glide to golang/dep and also bump vendor #237
Migrate from glide to golang/dep and also bump vendor #237
Conversation
6a5e563
to
4ecc2ab
Compare
To get
Note: Some of these packages in
/cc @mattfarina, @marun. request to PTAL. esp bffc47b |
72590e5
to
ac7c391
Compare
@shashidharatd I was having a look at different commits. One thing that strikes me as a future problem is copying and maintaining the e2e framework into federation repo. I agree that is reduces the overall vendor size, but I would recommend to let the folks responsible for maintaining the k8s e2e fw, still maintain it. We can try to pitch our case for having that portion of code out of k/k for it to be easier to be used by other projects. |
@irfanurrehman, I agree and concur with your opinion. But importing the |
Agree. Thanks for doing this @shashidharatd. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: irfanurrehman, shashidharatd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks @irfanurrehman |
This PR does following things.
k8s.io/kubernetes/test/e2e/framework
(as it is one huge package and lot many unnecessary stuff gets imported. So pulled in only necessary funcs into a reusable package within federation)./cc @kubernetes/sig-multicluster-pr-reviews
/assign @irfanurrehman
p.s: Even though the PR is huge, most of it is either generated code or vendored code. So request to review commit by commit which is much easier.