Skip to content
This repository has been archived by the owner on Apr 21, 2019. It is now read-only.

Fix typos issues in master-helper.sh #285

Merged
merged 2 commits into from Nov 11, 2018

Conversation

mooncak
Copy link
Contributor

@mooncak mooncak commented Oct 7, 2018

Fix typos issues in below files:

  1. build/README.md
  2. cluster/gce/container-linux/master-helper.sh

Signed-off-by: mooncake <xcoder@tenxcloud.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 7, 2018
@k8s-ci-robot
Copy link
Contributor

Hi @mooncak. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 7, 2018
@mooncak
Copy link
Contributor Author

mooncak commented Oct 7, 2018

/assign @lavalamp @yifan-gu

@mooncak
Copy link
Contributor Author

mooncak commented Oct 11, 2018

/ok-to-test
/lgtm

@k8s-ci-robot
Copy link
Contributor

@mooncak: you cannot LGTM your own PR.

In response to this:

/ok-to-test
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mooncak
Copy link
Contributor Author

mooncak commented Oct 11, 2018

/assign @lavalamp @yifan-gu

@mooncak
Copy link
Contributor Author

mooncak commented Oct 12, 2018

/approve

@mooncak
Copy link
Contributor Author

mooncak commented Oct 14, 2018

/assign @lavalamp @yifan-gu

@mooncak
Copy link
Contributor Author

mooncak commented Oct 16, 2018

@lavalamp @yifan-gu @euank @zmerlynn could you pls help review and approve? tks.

build/README.md Outdated Show resolved Hide resolved
@mooncak
Copy link
Contributor Author

mooncak commented Oct 19, 2018

@lavalamp can you help approve this PR? thanks

@lavalamp
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 19, 2018
@euank
Copy link
Contributor

euank commented Oct 19, 2018

FWIW the files in cluster were originally mirrored from kubernetes/kubernetes, and the ones in the container-linux folder at least were not changed since being mirrored.

The container-linux portion of cluster has since been deleted from the upstream source, and should probably be deleted here too for similar reasons (unmaintained, possibly broken).

That being said, I don't exactly know the plan the federation folks have for this repo. It looks like they may have moved on to a different one.

I'm fine approving this, but if you want to make more meaningful changes in this repo, you should definitely reach out to the sig-federation first and see what the intent is for this repo is before spending any significant time on it.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: euank, lavalamp, mooncak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2018
@mooncak
Copy link
Contributor Author

mooncak commented Oct 24, 2018

/ok-to-test

@mooncak
Copy link
Contributor Author

mooncak commented Oct 30, 2018

@lavalamp can you add the /ok-to-test label?tks

@mooncak mooncak closed this Nov 3, 2018
@lavalamp
Copy link
Contributor

lavalamp commented Nov 6, 2018

sorry I didn't see this until now, if you reopen you can get anyone to add /ok-to-test

@mooncak mooncak reopened this Nov 11, 2018
@mooncak
Copy link
Contributor Author

mooncak commented Nov 11, 2018

sorry I didn't see this until now, if you reopen you can get anyone to add /ok-to-test

ok, thanks.

@k8s-ci-robot k8s-ci-robot merged commit 0a26710 into kubernetes-retired:master Nov 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants