Skip to content
This repository has been archived by the owner on Sep 24, 2021. It is now read-only.

Implement ImageStats API #288

Closed
resouer opened this issue Feb 8, 2018 · 7 comments
Closed

Implement ImageStats API #288

resouer opened this issue Feb 8, 2018 · 7 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@resouer
Copy link
Contributor

resouer commented Feb 8, 2018

For now, ImageStats is not implemented. Should fix it.

Caller in kubelet:

https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/kuberuntime/kuberuntime_image.go#L133

@resouer resouer added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Feb 8, 2018
@huanwei
Copy link

huanwei commented Feb 9, 2018

I will take a look!

@kincl
Copy link

kincl commented Apr 30, 2018

Running kube 1.9 and running into these errors that seem to be related:

E0430 09:31:05.013491   93659 remote_image.go:146] ImageFsInfo from image service failed: rpc error: code = Unavailable desc = grpc: the connection is unavailable
E0430 09:31:05.013525   93659 handler.go:276] HTTP InternalServerError serving /stats/summary: Internal Error: failed to get imageFs stats: rpc error: code = Unavailable desc = grpc: the connection is unavailable
I0430 09:31:19.910221   93659 kuberuntime_manager.go:514] Container {Name:test-3 Image:busybox:latest Command:[/bin/sh] Args:[] WorkingDir: Ports:[] EnvFrom:[] Env:[] Resources:{Limits:map[] Requests:map[]} VolumeMounts:[{Name:default-token-0n55z ReadOnly:true MountPath:/var/run/secrets/kubernetes.io/serviceaccount SubPath: MountPropagation:<nil>}] VolumeDevices:[] LivenessProbe:nil ReadinessProbe:nil Lifecycle:nil TerminationMessagePath:/dev/termination-log TerminationMessagePolicy:File ImagePullPolicy:IfNotPresent SecurityContext:nil Stdin:false StdinOnce:false TTY:false} is dead, but RestartPolicy says that we should restart it.
E0430 09:31:19.910374   93659 remote_image.go:83] ImageStatus "busybox:latest" from image service failed: rpc error: code = Unavailable desc = grpc: the connection is unavailable
E0430 09:31:19.910440   93659 kuberuntime_image.go:86] ImageStatus for image {"busybox:latest"} failed: rpc error: code = Unavailable desc = grpc: the connection is unavailable
E0430 09:31:19.910495   93659 kuberuntime_manager.go:734] container start failed: ImageInspectError: Failed to inspect image "busybox:latest": rpc error: code = Unavailable desc = grpc: the connection is unavailable
E0430 09:31:19.910530   93659 pod_workers.go:186] Error syncing pod 188526d0-4c7a-11e8-8a6a-0050569b14aa ("test-3_default(188526d0-4c7a-11e8-8a6a-0050569b14aa)"), skipping: failed to "StartContainer" for "test-3" with ImageInspectError: "Failed to inspect image \"busybox:latest\": rpc error: code = Unavailable desc = grpc: the connection is unavailable"

It appears that the container will not start if the kubelet cannot get image stats.

@kincl
Copy link

kincl commented Apr 30, 2018

I solved my problem by setting --image-service-endpoint=unix:///var/run/frakti.sock in addition to --container-runtime-endpoint in the kubelet. This way frakti returns a Not Implemented error and the kublet allows the pod to be created.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 4, 2018
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 4, 2018
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

5 participants