Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

import-boss: add inverse import rules #154

Merged
merged 1 commit into from
Oct 10, 2019
Merged

import-boss: add inverse import rules #154

merged 1 commit into from
Oct 10, 2019

Conversation

eloyekunle
Copy link
Contributor

Continues from #116 by @sttts.

Closes #116

@k8s-ci-robot
Copy link
Contributor

Welcome @eloyekunle!

It looks like this is your first PR to kubernetes/gengo 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/gengo has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 25, 2019
@eloyekunle eloyekunle changed the title wip: import-boss: add inverse import rules [wip]: import-boss: add inverse import rules Sep 25, 2019
sttts
sttts reviewed Sep 25, 2019
View reviewed changes
examples/import-boss/main.go Outdated Show resolved Hide resolved
@sttts
Copy link
Contributor

sttts commented Sep 25, 2019 •
edited

/cc @dims

This will allow us to disallow imports of packages in places we don't want, within the monorepo. Like internal packages from Golang, but much more flexible. I.e. it allows us to put up import barriers long before a package is actually moved into a staging repo. For example we could restrict that internal API types are only used inside of kube-apiserver.

@eloyekunle eloyekunle changed the title [wip]: import-boss: add inverse import rules import-boss: add inverse import rules Sep 28, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 28, 2019
@sttts
Copy link
Contributor

sttts commented Sep 30, 2019

Looks mostly good.

Can you squash in a sensible way?

@eloyekunle eloyekunle requested a review from sttts October 1, 2019 18:43
@eloyekunle eloyekunle mentioned this pull request Oct 5, 2019
Merged
@eloyekunle eloyekunle requested a review from sttts October 9, 2019 11:05
enxebre
enxebre reviewed Oct 9, 2019
View reviewed changes
parser/parse.go Outdated Show resolved Hide resolved
@sttts
Copy link
Contributor

sttts commented Oct 10, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 10, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eloyekunle, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2019
@k8s-ci-robot k8s-ci-robot merged commit 7fa3014 into kubernetes:master Oct 10, 2019
@eloyekunle eloyekunle deleted the import-boss-inverse branch October 10, 2019 09:46
@enxebre enxebre mentioned this pull request Feb 5, 2020
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enxebre enxebre enxebre left review comments

@lavalamp lavalamp Awaiting requested review from lavalamp

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

@dims dims Awaiting requested review from dims

@sttts sttts Awaiting requested review from sttts

Assignees

@sttts sttts

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@eloyekunle @k8s-ci-robot @sttts @enxebre