Add GC controls, e2e regexes (v3 branch) #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular, this sets `gc.autoDetach` to "false".
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
the
approved
Values: * "auto" - run `git gc --auto` (default, respects git gc.* configs) * "always" - run `git gc` * "aggressive" - run `git gc --aggressive` (may require a longer timeout) * "off" - do not run `git gc` on each sync (good for --one-time use)
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
OK, I think this is ready for review. |
thockin
changed the title
|
ping on this if anyone cares |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stp-ip, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Might wanna update the Readme with the latest gc arg. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking for feedback, re: #439. This does not solve the timeout problem, and it does not do ideal repo-packing, but that is bigger and will have to come in v4 only.
Set
gc.autoDetachto "false"Add
--git-gcflag to control GC on each syncValues:
git gc --auto(default, respects git gc.* configs)git gcgit gc --aggressive(may require a longer timeout)git gcon each sync (good for --one-time use)Also makes e2e test treat args as regexes.