Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document V4 regression on --change-permissions #809

Merged
merged 1 commit into from
Oct 1, 2023
Merged

Document V4 regression on --change-permissions #809

merged 1 commit into from
Oct 1, 2023

Conversation

thockin
Copy link
Member

@thockin thockin commented Sep 19, 2023

Possible docs-fix for #807 . A real fix is either gross (bring back --change-permissions) or more complex (make a new flag which is more sophisticated, like --chmod="glob=mode". IMO, this belongs in the repo, not in the client.

For discussion

@thockin thockin added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 19, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 19, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 19, 2023
@thockin
Add v4 note about change-permissions and exechook
e394c5c 
This is sort of a regression in v4 vs, v3, but ths use case is pretty
niche, I think.
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 20, 2023
@thockin thockin changed the title V4 regress change perms Document V4 regression on --change-permissions Sep 21, 2023
@thockin thockin merged commit 7da482e into kubernetes:master Oct 1, 2023
4 of 5 checks passed
@Porkepix Porkepix mentioned this pull request Oct 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nan-yu nan-yu Awaiting requested review from nan-yu

@stp-ip stp-ip Awaiting requested review from stp-ip

Assignees

@stp-ip stp-ip

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thockin @k8s-ci-robot @stp-ip