Add the idea of "env-flags" #886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
thockin
force-pushed
the
add-env-params
branch
2 times, most recently
from
62bf93a
to
96ff5c1
Compare
thockin
added
the
do-not-merge/hold
thockin
force-pushed
the
add-env-params
branch
3 times, most recently
from
86372ad
to
d61932f
Compare
thockin
force-pushed
the
add-env-params
branch
6 times, most recently
from
a5b4076
to
4597da9
Compare
Env-flags are "flags" that can only be set by env var (see caveat below). All of the real flags have a corresponding env-flag (kind of, but not really). The real goal was to deprecate `--password` but keep the env var as a documented interface. This does that (though --password still works) and updates the usage and manual. This allows some future work to follow the pattern. We do not register every CLI flag as an env-flag because the help text would be duplicative. This probably wants a wrapper API that allows declaring of abstract flags, with CLI, env, or both sources. Caveat: ACTUALLY, these still have a flag, but the flag is specially named and hidden. This makes testing a little easier where passing flags is handled well but env vars is not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Env-flags are flags that can only be set by env var. All of the real
flags have a corresponding env-flag, kind of. The real goal was to
deprecate
--passwordbut keep the env var as a documented interface.This does that (though --password still works) and updates the usage and
manual.
This allows some future work to follow the pattern.