Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

original http request origin and host headers are overriden #179

Closed
sht5 opened this issue Mar 29, 2018 · 8 comments
Closed

original http request origin and host headers are overriden #179

sht5 opened this issue Mar 29, 2018 · 8 comments
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@sht5
Copy link

sht5 commented Mar 29, 2018

when my client makes an http request to the Ingress domain i see that the request origin and host headers are sent correctly but on my backend i can see they are changed by Ingress to some internal ip. This is crucial for setting up CORS for my app ( checks domain and alters response headers accordingly).

@sabinthomas
Copy link

Any update on this? I've looked at all the request headers on the request forwarded from the GCE Ingress, and I can't find anything that exposes the origin IP?

x-forwarded-for
x-real-ip

In the absence of this ability, I may have to move to using the nginx ingress.

@rramkumar1
Copy link
Contributor

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 23, 2018
@bowei
Copy link
Member

bowei commented Aug 23, 2018

Hi, can you post your headers that you are seeing on your application side?
According to this page: https://cloud.google.com/load-balancing/docs/https/, you should be seeing x-forwarded-for

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 21, 2018
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 21, 2018
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rramkumar1 rramkumar1 removed the kind/feature Categorizes issue or PR as related to a new feature. label Feb 18, 2019
@synvestable
Copy link

Hi, can you guys add some insight to this? This is a security bug if there's no feature to cover it, can't use in prod.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

7 participants