Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingress tries to create SSL certificate from secret with illegal name #321

Closed
rgfunk opened this issue Jun 8, 2018 · 3 comments
Closed
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@rgfunk
Copy link

rgfunk commented Jun 8, 2018

With revision acbecb5 the naming for SSL certificates created from secrets was changed to include the ingress-uid as a suffix (in namer.go). However, clusters with ingress resources created before kubernetes version 1.3 have an empty ingress-uid, as described here:

https://github.com/kubernetes/ingress-gce/blob/master/BETA_LIMITATIONS.md#changing-the-cluster-uid

This leads to an illegal name for the ssl certificate (ending in "--"). Setting the uid is not an option as this would require deleting all ingress resources, which is currently not possible. It would be great if the naming supported a fallback in case the ingress-uid is not set.

The creation of all other ingress resources works fine without having the ingress-uid set.

@bowei bowei added the kind/bug Categorizes issue or PR as related to a bug. label Jun 10, 2018
@bowei
Copy link
Member

bowei commented Jun 11, 2018

/assign @prameshj

@k8s-ci-robot
Copy link
Contributor

@bowei: GitHub didn't allow me to assign the following users: prameshj.

Note that only kubernetes members and repo collaborators can be assigned.

In response to this:

/assign @prameshj

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@prameshj
Copy link
Contributor

I'll work on a fix for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

4 participants