Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create corresponding Neg CRs when NEG CRD is enabled #1172

Merged
merged 2 commits into from
Jul 18, 2020
Merged

Create corresponding Neg CRs when NEG CRD is enabled #1172

merged 2 commits into from
Jul 18, 2020

Conversation

swetharepakula
Copy link
Member

Controller accepts custom names and manager will create CRs per NEG when NEG CRD is enabled.

This PR is based on PR #1166

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 6, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @swetharepakula. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 6, 2020
freehan
freehan reviewed Jul 7, 2020
View reviewed changes
pkg/neg/manager.go Outdated Show resolved Hide resolved
pkg/neg/manager.go Outdated Show resolved Hide resolved
pkg/neg/manager.go Outdated Show resolved Hide resolved
pkg/neg/manager.go Outdated Show resolved Hide resolved
pkg/neg/manager.go Outdated Show resolved Hide resolved
pkg/neg/manager.go Outdated Show resolved Hide resolved
pkg/neg/manager.go Outdated Show resolved Hide resolved
pkg/neg/manager.go Outdated Show resolved Hide resolved
@swetharepakula swetharepakula force-pushed the neg-crd-manager branch 4 times, most recently from fdac6ae to ad3e0ef Compare July 10, 2020 00:50
@swetharepakula swetharepakula marked this pull request as ready for review July 10, 2020 00:52
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 10, 2020
@freehan
Copy link
Contributor

freehan commented Jul 10, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 10, 2020
freehan
freehan reviewed Jul 13, 2020
View reviewed changes
pkg/context/context.go Outdated Show resolved Hide resolved
pkg/neg/manager.go Outdated Show resolved Hide resolved
pkg/neg/manager.go Outdated Show resolved Hide resolved
@swetharepakula swetharepakula force-pushed the neg-crd-manager branch 2 times, most recently from 74a80fa to f8832e7 Compare July 15, 2020 00:30
freehan
freehan reviewed Jul 15, 2020
View reviewed changes
pkg/context/context.go Outdated Show resolved Hide resolved
pkg/neg/manager.go Outdated Show resolved Hide resolved
pkg/neg/manager.go Outdated Show resolved Hide resolved
pkg/neg/manager.go Outdated Show resolved Hide resolved
pkg/neg/manager.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 16, 2020
freehan
freehan reviewed Jul 16, 2020
View reviewed changes
pkg/neg/manager.go Outdated Show resolved Hide resolved
pkg/neg/manager.go Outdated Show resolved Hide resolved
@swetharepakula
Add negClient to ControllerContext
32b9c29
@swetharepakula
Create Neg CRs when neg crd is enabled
78b4ff1 
  - when EnableNegCrd flag is set, neg client is created
  - manager will create neg crs when creating syncers
  - manager will delete neg crs when deleting syncers for removed ports
  - manager throws errors if custom names are specified when ingress is
  desired or if neg crd is not enabled
freehan
freehan approved these changes Jul 18, 2020
View reviewed changes
Copy link
Contributor

@freehan freehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 18, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: freehan, swetharepakula

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 18, 2020
@k8s-ci-robot k8s-ci-robot merged commit 0a4d7d3 into kubernetes:master Jul 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freehan freehan freehan approved these changes

@thockin thockin Awaiting requested review from thockin

Assignees

@freehan freehan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@swetharepakula @k8s-ci-robot @freehan