Cleanup L4 ILB IP Reservation in all cases. #1181
Conversation
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
needs-rebase
|
@freehan This is now ready for review. |
| @@ -261,6 +261,12 @@ func (l *L4) ensureForwardingRule(loadBalancerName, bsLink string, options gce.I | |||
| return nil, err | |||
| } | |||
| klog.V(2).Infof("ensureForwardingRule(%v): reserved IP %q for the forwarding rule", loadBalancerName, ipToUse) | |||
| defer func() { | |||
| // Now that the controller knows the forwarding rule exists, we can release the address. | |||
There was a problem hiding this comment.
add a comment to explain: why no need to hold the address after the forwarding rule exists?
Plus, the following logic may also fail right? For instance, the following logic hit a quota limit and failed to create forwarding rule?
So I guess, it should always release the address to avoid leaking address?
There was a problem hiding this comment.
Yes that's correct. I fixed the comment.
Reservation for IP is made for new FR, updated FR and periodic sync. Cleanup reservation after FR has been ensured in all cases.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: freehan, prameshj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This is a follow up to #1179, the previous PR cleaned up the reservation in case of new Forwarding rule creation or on updates. But, reservation also happens during periodic syncs which need to be cleaned up.
/assign @freehan @bowei