Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new flag for configuring metrics export frequency #1693

Merged
merged 1 commit into from
Apr 12, 2022
Merged

Add new flag for configuring metrics export frequency #1693

merged 1 commit into from
Apr 12, 2022

Conversation

cezarygerard
Copy link
Contributor

  • Add new flag for configuring metrics export.
  • Modify tests to use naive fake for controller metrics

This will allow us to increase export frequency to comply with sampling theorem: https://en.wikipedia.org/wiki/Nyquist%E2%80%93Shannon_sampling_theorem

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 6, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @cezarygerard. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 6, 2022
@bowei
Copy link
Member

bowei commented Apr 7, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 7, 2022
@bowei
Copy link
Member

bowei commented Apr 8, 2022

Can you put the reason to make this a flag instead of just changing the constant?

@bowei
Copy link
Member

bowei commented Apr 8, 2022

(Add to commit message)

@cezarygerard
Add new flag for configuring metrics export frequency
24156b8 
We need to increase the frequency to at least 1/5minutes, but this may not be the final value.
From observability POV the more frequent the better.
With this change we can tune the frequency without rebuilding the binary, and without releasing new tags.

This will allow us to increase export frequency to comply with sampling theorem
https://en.wikipedia.org/wiki/Nyquist%E2%80%93Shannon_sampling_theorem
@cezarygerard
Copy link
Contributor Author

Added the rationale to the commit message

@cezarygerard
Copy link
Contributor Author

/assign @freehan

freehan
freehan approved these changes Apr 12, 2022
View reviewed changes
Copy link
Contributor

@freehan freehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 12, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cezarygerard, freehan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 12, 2022
@k8s-ci-robot k8s-ci-robot merged commit e9fec8e into kubernetes:master Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freehan freehan freehan approved these changes

@MrHohn MrHohn Awaiting requested review from MrHohn

@swetharepakula swetharepakula Awaiting requested review from swetharepakula

Assignees

@freehan freehan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cezarygerard @k8s-ci-robot @bowei @freehan