Create Forwarding Rules provider

[panslava]

This separates "business" logic of creating forwarding rules for our controllers, from interacting with forwarding rules in google cloud

This removes copy pasted code between l4 ilb and l4 elb

[swetharepakula]

Perhaps Manager instead of controller so it isn't considered the same as the actual controllers?

[panslava]

Definitely agree, I actually wanted to ask for help with the name, cause also felt that in this project “controller” has its own meaning
Thanks!

[panslava]

I am thinking, maybe ForwardingRulesService will be better?

[panslava]

But I am still not very sure, and even Inteliji gives warning like "Name starts with the package name"

[panslava]

Actually, I think interface should be named

ForwardingRulesManager (and it is good that it ends on "er")

and struct will be just

ForwardingRules (and even in Inteliji checker, they are happy with this name, as it matches the package)

[panslava]

I am also not 100% sure about naming, should methods name contain "ForwardingRule", so we would call them

l.forwardingRules.DeleteForwardingRule

or it is better to not double the name, so they would be

l.forwardingRules.Delete

(personally, I think option 2 is better)

[panslava]

/assign cezarygerard

[panslava]

/assign bowei

[cezarygerard]

I see most of the forwarding rules logic iI see most of the forwarding rules logic is still in the
pkg/loadbalancers/forwarding_rules.go

do you think you can move more here?
or the rest of the logic is L4 specific?
if so

• do you plan to split the pkg/loadbalancers/forwarding_rules.go into l4-/l4netlb-/l7-forwarding_rules.go files?s still in the

[panslava]

/hold

I will squash before merging (after approve)

[cezarygerard]

/lgtm
thanks for addressing the comments
please squash and unhold

[panslava]

/unhold

[cezarygerard]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cezarygerard, panslava

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [cezarygerard,panslava]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment