Refactor l4_test assertInternalLbResourcesDeleted function #1805
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
|
/assign cezarygerard |
panslava
force-pushed
the
refactor-l4_test-assert-delete
branch
from
d82032a
to
7ee7b9d
Compare
k8s-ci-robot
added
size/L
pkg/loadbalancers/l4_test.go
Outdated
| t.Errorf("verifyHealthCheckNotExists(_, %s)", hcNameShared) | ||
| } | ||
|
|
||
| hcNameNonShared := l4.namer.L4HealthCheck(l4.Service.Namespace, l4.Service.Name, true) |
There was a problem hiding this comment.
last arg should be false
or better:
last arg should be named variable
or event better
L4ResourcesNamer interface should have 2 methods, with no bool arg
- L4SharedHealthCheck
- L4NonSharedHealthCheck
also currently make test passes so it means the tests are rather poor :-/
maybe create and delete ilb service with externaltrafficpolicy:local ?
There was a problem hiding this comment.
Thank you for catching this, fixed
I agree about namer, but I don't think it should be changed in this PR
make test passes, but it is hard to imagine them to fall in this "typo" case, even in perfect scenario, cause we just checking twice that sharedHC was deleted
There was a problem hiding this comment.
make test passes, but it is hard to imagine them to fall in this "typo" case, even in perfect scenario, cause we just checking twice that sharedHC was deleted
right, you would need to fix the the test AND break the actual controller logic, to see the test fail :-/
NVM
panslava
force-pushed
the
refactor-l4_test-assert-delete
branch
from
7ee7b9d
to
ebc0eab
Compare
panslava
requested review from
cezarygerard
and removed request for
rramkumar1
|
Slavik, please add proper description to this PR |
|
@cezarygerard thank you, done |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cezarygerard, panslava The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Split assertInternalLbResourcesDeleted function in l4_test to smaller functions which separately check that forwarding rule, health check, firewall etc were deleted