Fix deletion of address in l4 #1814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
panslava
force-pushed
the
l4-delete-proper-address
branch
from
4b601f1
to
76a24d4
Compare
|
/assign @kl52752 |
kl52752
reviewed
Sep 15, 2022
| @@ -118,7 +118,7 @@ func (l4 *L4) EnsureInternalLoadBalancerDeleted(svc *corev1.Service) *L4ILBSyncR | |||
| result.Error = err | |||
| result.GCEResourceInError = annotations.ForwardingRuleResource | |||
| } | |||
| if err = ensureAddressDeleted(l4.cloud, name, l4.cloud.Region()); err != nil { | |||
| if err = ensureAddressDeleted(l4.cloud, frName, l4.cloud.Region()); err != nil { | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
thank you, good suggestion, done
We were trying to delete address with backend service name, but we only reserve address with forwarding rule name Remove frName argument from ensureForwardingRule, and instead construct the name on the fly
panslava
force-pushed
the
l4-delete-proper-address
branch
from
76a24d4
to
6c9120a
Compare
k8s-ci-robot
added
size/S
panslava
requested review from
kl52752
and removed request for
cezarygerard and
thockin
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kl52752, panslava The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were trying to delete address with backend service name, but we only reserve address with forwarding rule name