Remove using node ports for L4 NetLB RBS Services #1907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NodePorts are not needed for NetLB RBS and were copied from legacy implementation. They were also slowing down our controller, because we were updating same instance group with node port for every service
k8s-ci-robot
added
the
cncf-cla: yes
|
/assign cezarygerard |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
size/S
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cezarygerard, panslava The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cezarygerard
added a commit
to cezarygerard/ingress-gce
that referenced
this pull request
Jan 26, 2023
It is not used anymore after PR kubernetes#1907
swetharepakula
pushed a commit
to swetharepakula/ingress-gce
that referenced
this pull request
Jan 27, 2023
It is not used anymore after PR kubernetes#1907
k8s-ci-robot
added a commit
that referenced
this pull request
Feb 13, 2023
[Cherry pick #1907] to release 1.20 Remove using node ports for L4 NetLB RBS Services
code-elinka
pushed a commit
to akhmanova/ingress-gce
that referenced
this pull request
Apr 18, 2023
It is not used anymore after PR kubernetes#1907
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NodePorts are not needed for NetLB RBS and were copied from legacy implementation. They were also slowing down our controller, because we were updating same instance group with node port for every service