Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code gen process and pin dependencies for update-codegen.sh #1914

Merged
merged 5 commits into from
Jan 25, 2023

Conversation

aojea
Copy link
Member

@aojea aojea commented Jan 25, 2023

Closes #1870
Closes #1855

This incorporates the great work of @gauravkghildiyal fixing the update codegen script.

In addition:

  • add verify scripts and makefile target to use make verify
  • make the update codegen script non-interactive so it can run on CI
  • bump the golang ci lint version to fix a problem
  • run update codegen to update current code

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 25, 2023
@aojea
Copy link
Member Author

aojea commented Jan 25, 2023

@k8s-ci-robot
Copy link
Contributor

@aojea: GitHub didn't allow me to assign the following users: spencerhance, gauravkghildiyal.

Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @swetharepakula @spencerhance @gauravkghildiyal

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aojea aojea mentioned this pull request Jan 25, 2023
@@ -1,5 +1,5 @@
/*
Copyright 2022 The Kubernetes Authors.
Copyright 2023 The Kubernetes Authors.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spencerhance do we need to update these fails constantly?
I mean, every year this is going to fail

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, this doesn't feel necessary.

@swetharepakula
Copy link
Member

Thanks @gauravkghildiyal & @aojea.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 25, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, swetharepakula

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 25, 2023
@k8s-ci-robot k8s-ci-robot merged commit 92eb7b9 into kubernetes:master Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pin dependencies of update-codegen.sh Cannot use the script /hack/update-codegen.sh
4 participants