Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add getPodLabelMap function for NegLabelPropagation and add unit test for it #1990

Merged
merged 4 commits into from
Apr 5, 2023
Merged

Add getPodLabelMap function for NegLabelPropagation and add unit test for it #1990

merged 4 commits into from
Apr 5, 2023

Conversation

songrx1997
Copy link
Contributor

@songrx1997 songrx1997 commented Mar 9, 2023 •
edited
Loading

Add EndpointAnnotationMap to negtypes

Add getPodLabelMap function and truncateLabel function for label propagation

Add unit tests

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 9, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @songrx1997. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 9, 2023
@k8s-ci-robot k8s-ci-robot requested review from aojea and bowei March 9, 2023 19:21
@songrx1997
Copy link
Contributor Author

/assign @swetharepakula

@songrx1997 songrx1997 force-pushed the label-propagation-getPodLabelMap branch from ae47cc9 to 5b502ef Compare March 15, 2023 02:40
@swetharepakula
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 16, 2023
swetharepakula
swetharepakula reviewed Mar 17, 2023
View reviewed changes
Copy link
Member

@swetharepakula swetharepakula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good. Need to add some logging and way to publish events when we truncate labels.

pkg/neg/syncers/utils.go Outdated Show resolved Hide resolved
pkg/neg/syncers/utils.go Outdated Show resolved Hide resolved
pkg/neg/syncers/utils.go Outdated Show resolved Hide resolved
@songrx1997 songrx1997 force-pushed the label-propagation-getPodLabelMap branch 2 times, most recently from c2b6815 to aabb3b1 Compare March 17, 2023 02:53
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 17, 2023
@songrx1997 songrx1997 force-pushed the label-propagation-getPodLabelMap branch from aabb3b1 to 4d3baf7 Compare March 17, 2023 18:13
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 17, 2023
@songrx1997 songrx1997 force-pushed the label-propagation-getPodLabelMap branch from 4d3baf7 to ce130ec Compare March 17, 2023 23:43
bowei
bowei reviewed Mar 18, 2023
View reviewed changes
pkg/neg/syncers/utils.go Outdated Show resolved Hide resolved
bowei
bowei reviewed Mar 18, 2023
View reviewed changes
pkg/neg/syncers/utils.go Outdated Show resolved Hide resolved
@songrx1997 songrx1997 force-pushed the label-propagation-getPodLabelMap branch 5 times, most recently from a443873 to 1053d01 Compare March 21, 2023 23:53
@songrx1997 songrx1997 force-pushed the label-propagation-getPodLabelMap branch 3 times, most recently from 16b3406 to 794d794 Compare March 27, 2023 21:43
@songrx1997 songrx1997 force-pushed the label-propagation-getPodLabelMap branch 6 times, most recently from b2ab308 to 553789e Compare March 30, 2023 20:31
swetharepakula
swetharepakula reviewed Apr 3, 2023
View reviewed changes
pkg/neg/syncers/labels/labels.go Outdated Show resolved Hide resolved
pkg/neg/syncers/labels/labels.go Outdated Show resolved Hide resolved
pkg/neg/syncers/labels/labels.go Outdated Show resolved Hide resolved
pkg/neg/syncers/labels/labels.go Outdated Show resolved Hide resolved
pkg/neg/syncers/labels/labels.go Outdated Show resolved Hide resolved
@songrx1997 songrx1997 force-pushed the label-propagation-getPodLabelMap branch 4 times, most recently from e532379 to ed0db8e Compare April 3, 2023 22:39
bowei
bowei reviewed Apr 4, 2023
View reviewed changes
pkg/neg/syncers/labels/labels.go Outdated Show resolved Hide resolved
pkg/neg/syncers/labels/labels.go Show resolved Hide resolved
pkg/neg/syncers/labels/labels.go Outdated Show resolved Hide resolved
pkg/neg/syncers/labels/labels.go Outdated Show resolved Hide resolved
pkg/neg/syncers/labels/labels.go Outdated Show resolved Hide resolved
@bowei
Copy link
Member

bowei commented Apr 4, 2023

Ruixian -- can you resolve comments that are done?

@songrx1997 songrx1997 force-pushed the label-propagation-getPodLabelMap branch from ed0db8e to 3d60388 Compare April 4, 2023 21:47
@songrx1997 songrx1997 force-pushed the label-propagation-getPodLabelMap branch from 3d60388 to 1570c3c Compare April 4, 2023 23:00
swetharepakula
swetharepakula reviewed Apr 4, 2023
View reviewed changes
Copy link
Member

@swetharepakula swetharepakula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small changes needed. This PR is almost ready to be merged.

pkg/neg/syncers/labels/labels.go Outdated Show resolved Hide resolved
pkg/neg/syncers/labels/labels.go Outdated Show resolved Hide resolved
pkg/neg/syncers/labels/label_test.go Outdated Show resolved Hide resolved
pkg/neg/syncers/labels/label_test.go Outdated Show resolved Hide resolved
@songrx1997 songrx1997 force-pushed the label-propagation-getPodLabelMap branch from 1570c3c to 09c4b94 Compare April 5, 2023 00:01
@songrx1997 songrx1997 force-pushed the label-propagation-getPodLabelMap branch from 09c4b94 to 8959e5a Compare April 5, 2023 00:55
swetharepakula
swetharepakula reviewed Apr 5, 2023
View reviewed changes
Copy link
Member

@swetharepakula swetharepakula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 5, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: songrx1997, swetharepakula

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 5, 2023
@k8s-ci-robot k8s-ci-robot merged commit 684710a into kubernetes:master Apr 5, 2023
@songrx1997 songrx1997 deleted the label-propagation-getPodLabelMap branch April 5, 2023 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowei bowei bowei left review comments

@swetharepakula swetharepakula swetharepakula left review comments

@gauravkghildiyal gauravkghildiyal gauravkghildiyal left review comments

@aojea aojea Awaiting requested review from aojea

Assignees

@bowei bowei

@swetharepakula swetharepakula

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@songrx1997 @k8s-ci-robot @swetharepakula @bowei @gauravkghildiyal