Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CheckServiceExistence Rule for gke-ingress-checker #2025

Merged
merged 2 commits into from
May 2, 2023
Merged

Add CheckServiceExistence Rule for gke-ingress-checker #2025

merged 2 commits into from
May 2, 2023

Conversation

songrx1997
Copy link
Contributor

@songrx1997 songrx1997 commented Mar 17, 2023 •
edited
Loading

Rename util package in gke-diagnoser to report
Add CheckServiceExistence rule for gke-ingress-checker
Add unit test for CheckServiceExistence rule

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 17, 2023
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 17, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @songrx1997. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 17, 2023
@songrx1997
Copy link
Contributor Author

/assign @swetharepakula
/assign @bowei

@songrx1997 songrx1997 force-pushed the CheckServiceExistence branch 2 times, most recently from 7ef0fef to a750aae Compare March 17, 2023 20:15
@bowei
Copy link
Member

bowei commented Mar 20, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 20, 2023
@bowei
Copy link
Member

bowei commented Mar 20, 2023

I thought we were going to rename the cmd name? The directory is still named gke-diagnoser. Let's not forget to fix this.

bowei
bowei reviewed Mar 20, 2023
View reviewed changes
cmd/gke-diagnoser/app/ingress/rule.go

func CheckServiceExistence(ns string, svcName string, client clientset.Interface) (*corev1.Service, string, string) {
svc, err := client.CoreV1().Services(ns).Get(context.TODO(), svcName, metav1.GetOptions{})
if err != nil {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to check that the error is actually a not found error.
If there was a different kind of error, you need to surface that to the user and also print a different message.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, thanks!

@bowei
Copy link
Member

bowei commented Mar 20, 2023

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 20, 2023
@songrx1997
Copy link
Contributor Author

I thought we were going to rename the cmd name? The directory is still named gke-diagnoser. Let's not forget to fix this.

Will rename the directory after current PRs merged

@songrx1997 songrx1997 force-pushed the CheckServiceExistence branch 3 times, most recently from ff09911 to ca3ebc4 Compare May 2, 2023 19:56
swetharepakula
swetharepakula reviewed May 2, 2023
View reviewed changes
Copy link
Member

@swetharepakula swetharepakula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

/hold cancel
The rename will be handled in a separate PR

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels May 2, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: songrx1997, swetharepakula

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 2, 2023
@k8s-ci-robot k8s-ci-robot merged commit 8256c7e into kubernetes:master May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowei bowei bowei left review comments

@swetharepakula swetharepakula swetharepakula left review comments

@aojea aojea Awaiting requested review from aojea

@prameshj prameshj Awaiting requested review from prameshj

Assignees

@bowei bowei

@swetharepakula swetharepakula

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@songrx1997 @k8s-ci-robot @bowei @swetharepakula