Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Dockerfile.echo base image #2087

Merged
merged 1 commit into from
Apr 27, 2023
Merged

Conversation

code-elinka
Copy link
Contributor

Debian:9 is too old to be used and
it needs to be updated

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 26, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 26, 2023
@aojea
Copy link
Member

aojea commented Apr 26, 2023

if we do this, is better to move to distroless images https://github.com/GoogleContainerTools/distroless

@code-elinka
Copy link
Contributor Author

if we do this, is better to move to distroless images https://github.com/GoogleContainerTools/distroless
Done, thank you. I tested that it runs:

elinka@elinka:~/ingress-gce$ docker run -it gcr.io/<personal-registry>/echo:local
I0426 16:04:20.608087       1 main.go:33] Starting echo: "v1.23.0-14-gc23429dde"

Tell me if you think there is a benefit to use nonroot version of that image. I am not aware of pros/cons

@code-elinka
Copy link
Contributor Author

/assign @aojea

@aojea
Copy link
Member

aojea commented Apr 27, 2023

in general the less privileges the best, but AFAIK this image is only used for test

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 27, 2023
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 27, 2023
@code-elinka
Copy link
Contributor Author

in general the less privileges the best, but AFAIK this image is only used for test

/lgtm /approve

Done:

Digest: sha256:09ba2fe4c13b4a623acb5289a866e2d06ecbffdcdb8d3532a43902e9d6709fa8
Status: Downloaded newer image for gcr.io/REGISTRY/echo:nonroot
I0427 08:44:14.366307       1 main.go:33] Starting echo: "v1.23.0-14-gc23429dde"

@aojea
Copy link
Member

aojea commented Apr 27, 2023

you have to rebase, commit 019d54a already merged

Debian:9 is too old to be used and
it needs to be updated,
moving to distroless-debian11
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 27, 2023
@code-elinka
Copy link
Contributor Author

oops

you have to rebase, commit 019d54a already merged

@aojea
Copy link
Member

aojea commented Apr 27, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 27, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, code-elinka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 356c78b into kubernetes:master Apr 27, 2023
@code-elinka code-elinka deleted the patch-3 branch August 10, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants