Delete RBS annotation explicitly in preventTargetPoolRaceWithRBSOnCreation #2145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation As we removed deleting RBS annotation in garbageCollectRBSNetLB we now need to remove annotation explicitly, otherwise service will not be handled by legacy controller
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cezarygerard, panslava The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
aojea
reviewed
May 25, 2023
| @@ -316,7 +316,7 @@ func (lc *L4NetLBController) preventTargetPoolRaceWithRBSOnCreation(service *v1. | |||
| "Failed to clean RBS resources for load balancer with target pool, err: %v", result.Error) | |||
| return result.Error | |||
| } | |||
| return nil | |||
| return lc.deleteRBSAnnotation(service) | |||
There was a problem hiding this comment.
this seems to mutate the object, is it considering that the object belong to the cache or the passed service is a copy?
There was a problem hiding this comment.
Good question. Can I ask you, what problem appears when we mutate cache object?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we removed deleting RBS annotation in garbageCollectRBSNetLB we now need to remove annotation explicitly, otherwise service will not be handled by legacy controller
/assign @cezarygerard