Add GCE Request Count Metric #2150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
|
/hold a larger cleanup of the metrics is needed before this can go in |
k8s-ci-robot
added
the
do-not-merge/hold
Merged
swetharepakula
force-pushed
the
gce-request-count
branch
from
8f070cd
to
ba3e25f
Compare
k8s-ci-robot
added
size/XL
|
This is based on #2153 . I will rebase and remove hold once that is merged |
swetharepakula
force-pushed
the
gce-request-count
branch
3 times, most recently
from
df5e048
to
6440f54
Compare
k8s-ci-robot
added
size/M
|
#2153 has merged, so removing hold |
k8s-ci-robot
removed
the
do-not-merge/hold
pkg/neg/metrics/metrics.go
Outdated
| func PublishGCERequestCountMetrics(start time.Time, requestType string, err error) { | ||
| result := getResult(err) | ||
| GCERequestLatency.WithLabelValues(requestType, result).Observe(time.Since(start).Seconds()) | ||
| GCERequestCount.WithLabelValues(requestType, getResult(err)).Inc() |
There was a problem hiding this comment.
nit: Possible replacement: getResult(err) -> result
There was a problem hiding this comment.
Yes, thanks for catching that!
swetharepakula
force-pushed
the
gce-request-count
branch
from
6440f54
to
0a680ea
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gauravkghildiyal, swetharepakula The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add GCE Request Count Metric that measures the number of requests the NEG Controller sends to the NEG API
/assign @gauravkghildiyal