Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherrypick: Fix multiple secrets with same certificate #216

Merged
merged 1 commit into from
Apr 16, 2018
Merged

Cherrypick: Fix multiple secrets with same certificate #216

merged 1 commit into from
Apr 16, 2018

Conversation

nicksardo
Copy link
Contributor

@nicksardo nicksardo commented Apr 13, 2018 •
edited
Loading

Cherrypick fix #213 for release 1.1

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 13, 2018
@nicksardo
Copy link
Contributor Author

/hold
Wait for a few test runs against head.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 13, 2018
@nicksardo nicksardo changed the base branch from master to release-1.1 April 13, 2018 17:35
@nicksardo
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 16, 2018
@rramkumar1
Copy link
Contributor

Tests from the weekend look good.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 16, 2018
@nicksardo nicksardo merged commit 6f3fe68 into kubernetes:release-1.1 Apr 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rramkumar1 rramkumar1 Awaiting requested review from rramkumar1

Assignees

@rramkumar1 rramkumar1

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nicksardo @rramkumar1 @k8s-ci-robot