Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update annotations.md #221

Merged
merged 1 commit into from
Apr 17, 2018
Merged

Update annotations.md #221

merged 1 commit into from
Apr 17, 2018

Conversation

buzzedword
Copy link
Contributor

This documentation mistakingly implies the prefix for pre-shared-cert is ingress.kubernetes.io, when it is actually ingress.gcp.kubernetes.io. Using the former will not create an HTTPS mapping in the GCLB, and does not emit any errors indicating there is an issue with the annotation.

This documentation mistakingly implies the prefix for `pre-shared-cert` is `ingress.kubernetes.io`, when it is actually `ingress.gcp.kubernetes.io`. Using the former will not create an HTTPS mapping in the GCLB, and does not emit any errors indicating there is an issue with the annotation.
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Apr 17, 2018
@k8s-ci-robot
Copy link
Contributor

Hi @buzzedword. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 17, 2018
@buzzedword
Copy link
Contributor Author

CLA has been signed.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 17, 2018
@nicksardo
Copy link
Contributor

/lgtm
Thanks for your PR.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 17, 2018
@nicksardo nicksardo merged commit 860b3e5 into kubernetes:master Apr 17, 2018
@buzzedword buzzedword deleted the patch-1 branch April 17, 2018 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants