Add util functions for backendConfig annotation #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
LGTM, will let bowei@ verify annotation value structure is as desired. |
MrHohn
force-pushed
the
backend-config-annotation
branch
from
e9cdf50
to
70eedf1
Compare
k8s-ci-robot
added
size/L
|
Revised and added |
MrHohn
force-pushed
the
backend-config-annotation
branch
2 times, most recently
from
2ed904d
to
75698ea
Compare
|
Updated to add one more |
nicksardo
reviewed
May 4, 2018
pkg/annotations/service.go
Outdated
| @@ -40,6 +40,15 @@ const ( | |||
| // 3. Adding this annotation on ingress. | |||
| NetworkEndpointGroupAlphaAnnotation = "alpha.cloud.google.com/load-balancer-neg" | |||
|
|
|||
| // BackendConfigKey is a stringified JSON with two fields: | |||
| // - "ports": a map of port names to backendConfig names | |||
There was a problem hiding this comment.
port names or port numbers? Or just port names?
There was a problem hiding this comment.
Thanks, changed to "port names or port numbers".
MrHohn
force-pushed
the
backend-config-annotation
branch
from
75698ea
to
f5bd393
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/assign @nicksardo @bowei