Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update healthcheck docs regarding containerPort #260

Merged
merged 1 commit into from
May 11, 2018
Merged

Update healthcheck docs regarding containerPort #260

merged 1 commit into from
May 11, 2018

Conversation

sonu27
Copy link
Contributor

@sonu27 sonu27 commented May 10, 2018

Fixes issue #241

@k8s-ci-robot
Copy link
Contributor

Hi @sonu27. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 10, 2018
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 10, 2018
@sonu27
Copy link
Contributor Author

sonu27 commented May 10, 2018

@nicksardo Let me know if this is clear enough :)

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 10, 2018
@nicksardo
Copy link
Contributor

nicksardo commented May 10, 2018

Thank you for creating this PR @sonu27! However, it's not matching the servicePort, it's matching the service's targetPort. It's also complicated because names can be used...

The pod's `containerPort` field must be defined.
The service's `targetPort` field must point to the pod port's `containerPort` value or `name`. Note that the `targetPort` defaults to the `port` value if not defined.

Feel free to re-phrase any of that.

This might make more sense
Ingress servicePort ▶ Service port.port || port.name
Service targetPort ▶ Pod port.containerPort || port.name
ReadinessProbe port ▶ Pod port.containerPort || port.name

@sonu27
Copy link
Contributor Author

sonu27 commented May 11, 2018

Your wording is good.

I was thinking of added the bottom bit, as it explains it cleanly but possibly too much :)

@nicksardo
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 11, 2018
@nicksardo nicksardo merged commit 8b12122 into kubernetes:master May 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants