Add more negative test cases for backend config #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
rramkumar1
reviewed
Jul 2, 2018
| }, | ||
| backendConfig: fuzz.NewBackendConfigBuilder("", "backendconfig-1"). | ||
| EnableCDN(true). | ||
| SetIAPConfig(true, "bar"). |
There was a problem hiding this comment.
Given how the code is written, you will actually have to create the secret "bar". Otherwise, it will return an error saying the secret does not exist, rather than the error we actually are testing for,
There was a problem hiding this comment.
Good catch, I'm seeing this:
Error during sync: error while evaluating the ingress spec: BackendConfig test-sandbox-48912bf33631f0fe/backendconfig-1 is not valid: error retrieving secret bar: secrets \"bar\" not found
Added the logic to actually create the secret "bar".
rramkumar1
reviewed
Jul 2, 2018
| @@ -95,7 +94,7 @@ func GetBackendConfigForServicePort(backendConfigLister cache.Store, svc *apiv1. | |||
| if err == annotations.ErrBackendConfigAnnotationMissing { | |||
| return nil, nil | |||
| } | |||
| return nil, ErrBackendConfigsFromAnnotation | |||
| return nil, err | |||
There was a problem hiding this comment.
What was the reason for the change here?
There was a problem hiding this comment.
It was meant to make the warning event more useful. Without this change, when annotation is in invalid format, user will see something like "error getting backend config" instead of "the annotation is invalid".
|
/lgtm |
k8s-ci-robot
added
the
lgtm
freehan
added a commit
that referenced
this pull request
Jul 9, 2018
Cherrypick #383: Unmask get backend config errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/assign @rramkumar1 @bowei