Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use HTTPS readiness probe for HTTP2 services because the Kubernetes A… #488

Merged
merged 2 commits into from
Oct 8, 2018
Merged

Use HTTPS readiness probe for HTTP2 services because the Kubernetes A… #488

merged 2 commits into from
Oct 8, 2018

Conversation

anuraaga
Copy link
Contributor

…PI does not make a distinction between HTTPS and HTTP2 for probes.

Fixes #487

Use HTTPS readiness probe for HTTP2 services because the Kubernetes A…
52885cc 
…PI does not make a distinction between HTTPS and HTTP2 for probes.
@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 21, 2018
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 21, 2018
@rramkumar1
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 2, 2018
@rramkumar1
Copy link
Contributor

/cc @agau4779

@k8s-ci-robot
Copy link
Contributor

@rramkumar1: GitHub didn't allow me to request PR reviews from the following users: agau4779.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @agau4779

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@anuraaga
Copy link
Contributor Author

anuraaga commented Oct 8, 2018

Hello - just checking in. Is there anything blocking this PR? It's a simple bug with a simple fix, so would be good to address sooner than later I think. @agau4779 @rramkumar1

agau4779
agau4779 approved these changes Oct 8, 2018
View reviewed changes
Copy link
Contributor

@agau4779 agau4779 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bowei
Copy link
Member

bowei commented Oct 8, 2018

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 8, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anuraaga, bowei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 8, 2018
@k8s-ci-robot k8s-ci-robot merged commit d6a9498 into kubernetes:master Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agau4779 agau4779 agau4779 approved these changes

@bowei bowei Awaiting requested review from bowei

@MrHohn MrHohn Awaiting requested review from MrHohn

Assignees

@bowei bowei

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@anuraaga @rramkumar1 @k8s-ci-robot @bowei @agau4779