Replace all uses of Snapshotter with CloudLister #590
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
Hi @agau4779. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
needs-ok-to-test
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
|
/assign @rramkumar1 @bowei |
agau4779
force-pushed
the
listers
branch
2 times, most recently
from
5ee003d
to
676f5e1
Compare
…ation that is solely used for garbage collection
|
Also can you squash commits? |
| if len(l) >= 2 { | ||
| uid = l[len(l)-1] | ||
| } | ||
| c := strings.Split(name, "-") | ||
| c := strings.Split(l[0], "-") |
There was a problem hiding this comment.
Why was there a change here?
There was a problem hiding this comment.
Example: k8s-um-test--uid1
The first split above (L208) splits by cluster delimiter (--), giving us ["k8s-um-test", "uid1"]. We need to split the first item of this by - in order to get the NameComponents, which should be ["k8s", "um", "test"]. Previously we split the full name, which gives us ["k8s", "um", "test", "", "", "uid1"], since we only cared about the first two items.
Does this make sense?
There was a problem hiding this comment.
Added some clarifying comments in the code.
There was a problem hiding this comment.
Got it. Now that I look at the previous code, I'm surprised it even worked lol.
add L7 to syncState simplify cloudlister. use named fields in namer_test remove Cloudlist interface in favor of List() ([]string, error) method
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: agau4779, rramkumar1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Follow-up to #514 .
Replace the use of /pkg/storage/pools.go (Snapshotter) with a CloudLister interface, to be called as-needed during Garbage Collection. This should reduce the number of calls we make to the GCE API, as well as make GC more reliable.
We will use this for L7 loadbalancers, InstanceGroups, and Backends.
Verified that this properly garbage collects IGs, Backends, and Loadbalancers (TargetProxies, Forwarding Rules, URL Maps) via manual testing