tolerate non zonal NEG included in the AggregatedList API response #820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
bowei
reviewed
Aug 9, 2019
| parts := strings.Split(key, "/") | ||
| if len(parts) != 2 { | ||
| return nil, fmt.Errorf("invalid key for AggregatedListNetworkEndpointGroup: %q", key) | ||
| continue |
| return nil, fmt.Errorf("invalid key for AggregatedListNetworkEndpointGroup: %q", key) | ||
| continue | ||
| } | ||
| if parts[0] != "zones" { |
| continue | ||
| } | ||
| if parts[0] != "zones" { | ||
| continue |
There was a problem hiding this comment.
this should definitely be logged as a warning?
| // zonal key is "zones/<zone name>" | ||
| // regional key is "regions/<region name>" | ||
| // global key is "global" | ||
| // TODO: use meta.scope as key | ||
| parts := strings.Split(key, "/") |
| @@ -72,10 +71,17 @@ func (a *cloudProviderAdapter) AggregatedListNetworkEndpointGroup() (map[string] | |||
| } | |||
| ret := map[string][]*compute.NetworkEndpointGroup{} | |||
| for key, byZone := range all { | |||
| // key is "zones/<zone name>" | |||
| // key is scope | |||
k8s-ci-robot
added
the
needs-rebase
k8s-ci-robot
removed
the
needs-rebase
bowei
reviewed
Aug 9, 2019
| parts := strings.Split(key, "/") | ||
| if len(parts) != 2 { | ||
| return nil, fmt.Errorf("invalid key for AggregatedListNetworkEndpointGroup: %q", key) | ||
| klog.V(4).Infof("Ignoring key %q from AggregatedListNetworkEndpointGroup response.", key) |
There was a problem hiding this comment.
let's do this to be more precise:
if len(parts) == 1 && parts[0] == "global" {
klog.V(4).Infof("Ignoring key %q as it is global", key)
continue
}
if len(parts) != 2 || parts[0] != aggregatedListZonalKeyPrefix {
klog.Warningf("Key %q is not in a known format, ignoring", key)
continue
}
… is included in the API response
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bowei, freehan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will send a follow up PR to switch to use meta.scope as key.
This PR is mostly for simple cherry-pick