Add CreateILBSubnet() call to all ilb e2e tests #870
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
Hi @spencerhance. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
size/M
spencerhance
force-pushed
the
add-subnet-to-ilb-e2e-tests
branch
from
0778edb
to
697acab
Compare
spencerhance
force-pushed
the
add-subnet-to-ilb-e2e-tests
branch
from
697acab
to
e6a0664
Compare
|
/assign @bowei |
| var ( | ||
| negVal = annotations.NegAnnotation{Ingress: true} | ||
| negAnnotation = map[string]string{ | ||
| annotations.NEGAnnotationKey: negVal.String()} |
There was a problem hiding this comment.
why not
anootations.NEGAnnotationKey: annotations.NegAnnotation{Ingress:true}.String()
There was a problem hiding this comment.
annotations.NegAnnotation{Ingress:true}.String()throws a compiler error since String() wants a pointer
There was a problem hiding this comment.
cannot call pointer method on annotations.NegAnnotation literal
| @@ -80,6 +83,11 @@ func TestILB(t *testing.T) { | |||
|
|
|||
| t.Logf("Ingress = %s", tc.ing.String()) | |||
|
|
|||
| // Create Subnet if it doesn't already exist | |||
| if err := e2e.CreateILBSubnet(s, "ilb-subnet-ingress-e2e", subnetCidr); err != nil && err != e2e.ErrSubnetExists { | |||
There was a problem hiding this comment.
might want to put a random suffix on the subnet name?
There was a problem hiding this comment.
I can but it won't change the behavior. We can only ever create one subnet throughout all the tests running in parallel.
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MrHohn, spencerhance The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This will ensure that all the tests have an ILB subnet in their region. Later, we can add tests which delete or migrate the subnet and test that behavior.