Support grpc_read_timeout and grpc_send_timeout

[Chehai]

Is this a request for help? (If yes, you should use our troubleshooting guide and community support channels, see https://kubernetes.io/docs/tasks/debug-application-cluster/troubleshooting/.): No

What keywords did you search in NGINX Ingress controller issues before filing this one? (If you have found any duplicates, you should instead reply there.): grpc timeout

---

Is this a BUG REPORT or FEATURE REQUEST? (choose one): FEATURE REQUEST

Nginx grpc upstream has its own timeout settings. It would be nice to be able to customize grpc timeouts just like proxy timeouts.

NGINX Ingress controller version: 0.14.0

Kubernetes version (use kubectl version):
Client Version: version.Info{Major:"1", Minor:"10", GitVersion:"v1.10.1", GitCommit:"d4ab47518836c750f9949b9e0d387f20fb92260b", GitTreeState:"clean", BuildDate:"2018-04-13T22:27:55Z", GoVersion:"go1.9.5", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"9", GitVersion:"v1.9.5", GitCommit:"f01a2bf98249a4db383560443a59bed0c13575df", GitTreeState:"clean", BuildDate:"2018-03-19T15:50:45Z", GoVersion:"go1.9.3", Compiler:"gc", Platform:"linux/amd64"}

Environment:

• Cloud provider or hardware configuration: AWS
• OS (e.g. from /etc/os-release): Ubuntu 16.04.4 TLS
• Kernel (e.g. uname -a): 4.4.0-1052-aws Ignore coverage profile files. #61-Ubuntu SMP Mon Feb 12 23:05:58 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
• Install tools: helm
• Others:

What happened:

What you expected to happen:

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know:

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[dittos]

I was disappointed to see this issue being stale, but I found that nginx.ingress.kubernetes.io/server-snippet annotation can be used to set timeout.

nginx.ingress.kubernetes.io/server-snippet: "grpc_read_timeout 3600s; grpc_send_timeout 3600s;"

It would be better if specific annotations for gRPC timeout to be added.

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[k8s-ci-robot]

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jayanmn]

I was disappointed to see this issue being stale, but I found that nginx.ingress.kubernetes.io/server-snippet annotation can be used to set timeout.
It would be better if specific annotations for gRPC timeout to be added.

https://docs.nginx.com/nginx-ingress-controller/configuration/ingress-resources/advanced-configuration-with-annotations/ seems to indicate setting the proxy-send-timeout and proxy-read-timeout adjusts corresponding gRPC setting.

(Not yet working but that could be due to my incorrect testing?)

The server-snippet is dis-allowed by our central platform team due to security concerns

[Anddd7]

I was disappointed to see this issue being stale, but I found that nginx.ingress.kubernetes.io/server-snippet annotation can be used to set timeout.
It would be better if specific annotations for gRPC timeout to be added.

https://docs.nginx.com/nginx-ingress-controller/configuration/ingress-resources/advanced-configuration-with-annotations/ seems to indicate setting the proxy-send-timeout and proxy-read-timeout adjusts corresponding gRPC setting.

(Not yet working but that could be due to my incorrect testing?)

The server-snippet is dis-allowed by our central platform team due to security concerns

same to me, we have to migrate server-snippet to common annotations.

I checked the code https://github.com/kubernetes/ingress-nginx/blob/main/rootfs/etc/nginx/template/nginx.tmpl#L351, there is no "grpc_*" config. Maybe https://docs.nginx.com/nginx-ingress-controller/configuration/ingress-resources/custom-annotations/ is a workaround, but i still want this be official annotations

[jayanmn]

https://docs.nginx.com/nginx-ingress-controller/configuration/ingress-resources/advanced-configuration-with-annotations/ seems to indicate setting the proxy-send-timeout and proxy-read-timeout adjusts corresponding gRPC setting.

Note based on chat with @Anddd7 - the above is referring nginx-by-nginx. k8s has different implementation, that definitely require code change.