Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLBC ingress: only handle annotated ingress #59

Closed
tamalsaha opened this issue Dec 14, 2016 · 4 comments
Closed

GLBC ingress: only handle annotated ingress #59

tamalsaha opened this issue Dec 14, 2016 · 4 comments

Comments

@tamalsaha
Copy link
Member

tamalsaha commented Dec 14, 2016

Hi,
We are running a HAProxy based ingress in our clusters. But for a few service, we would like to run GLBC ingress. I did not see any way to tell ingress controllers, which Ingress resource they can handle. Can Ingress controllers can only handle ingress that has a specific annotation applied to it (similar to how schedulers do it):

"ingress.alpha.kubernetes.io/controller": glbc

Here is a way I could see being implemented. Glbc controller adds a new flag --ingress-controller.

If --ingress-controller flag value is empty, then glbc should handle any Ingress that has no annotation "ingress.alpha.kubernetes.io/controller" or annotation set to "" string.

If --ingress-controller flag is not empty, then only handle Ingress that has
"ingress.alpha.kubernetes.io/controller" : "".

Thanks.

@bprashanth
Copy link
Contributor

@tamalsaha
Copy link
Member Author

@bprashanth , thanks for the link. I somehow missed the documentation on kubernetes.io/ingress.class. But I would still like a flag for both ingress controllers to disable default on mode. If that flag is set, then ingress controller's will not manage Ingress with kubernetes.io/ingress.class set to empty string.

@bprashanth
Copy link
Contributor

Yeah that makes sense, I'm guessing you mean --ingress-class=gce only handles ingresses with kubernetes.io/ingress.class=gce. Please send a pr if you have time.

tamalsaha pushed a commit to voyagermesh/voyager that referenced this issue Feb 1, 2017
 - if flag == "voyager", the you only handle  ingress that has voyager annotation
 - if flag == "", then handle no annotaion or voyager annotation

ref:
 - kubernetes/ingress-nginx#59
@bowei
Copy link
Member

bowei commented Oct 11, 2017

This issue was moved to kubernetes/ingress-gce#20

@bowei bowei closed this as completed Oct 11, 2017
hnrytrn pushed a commit to hnrytrn/ingress-nginx that referenced this issue Jun 20, 2018
* Rename monitor.lua module to statsd.monitor.lua

* Rename statsd.monitor.lua to statsd_monitor.lua
haoqing0110 referenced this issue in stolostron/management-ingress Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants