Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split large configuration file #7234

Open
adou0510 opened this issue Jun 10, 2021 · 19 comments
Open

split large configuration file #7234

adou0510 opened this issue Jun 10, 2021 · 19 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@adou0510
Copy link

we have more than 10000+ site ,the nginx.conf so big about 500M

@adou0510 adou0510 added the kind/bug Categorizes issue or PR as related to a bug. label Jun 10, 2021
@wangyysde
Copy link
Member

/cc @wangyysde

@longwuyuan
Copy link
Contributor

/kind feature
/remove-kind bug

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. and removed kind/bug Categorizes issue or PR as related to a bug. labels Jun 11, 2021
@AmazingTurtle
Copy link

maybe relates to #7232

@rikatz
Copy link
Contributor

rikatz commented Jun 13, 2021

This seems a good approach, but will need some effort to implement.

If someone wants to tackle on this one after we merge the support for v1 API in ingress nginx I would be glad to review it :)

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 11, 2021
@rikatz
Copy link
Contributor

rikatz commented Sep 11, 2021

/remove-lifecycle stale
Still want to look into this

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 11, 2021
@tao12345666333
Copy link
Member

I have done some thinking, but in this project, if we split the configuration file, what will be the benefit?

@tao12345666333
Copy link
Member

In the context of this project, the user is modifying and maintaining Ingress resources, not directly on the configuration file. I haven't thought of the benefits it can bring. cc @rikatz

@agile6v
Copy link
Contributor

agile6v commented Sep 20, 2021

Hi @tao12345666333 if I understand it correctly splitting configuration file can reduce the memory consumption. Because the current strategy is to render the whole configuration file, so if there are many ingress resources, the configuration will be very large and frequent changes can cause excessive consumption. Thanks.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 19, 2021
@rikatz
Copy link
Contributor

rikatz commented Dec 19, 2021

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 19, 2021
@rikatz
Copy link
Contributor

rikatz commented Apr 12, 2022

/assign

@iamNoah1
Copy link
Contributor

/triage accepted
/priority backlog

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/backlog Higher priority than priority/awaiting-more-evidence. labels Apr 12, 2022
@wangyysde
Copy link
Member

@rikatz Are you preparing a PR for this? I try to do it if you are not work for it.

@rikatz
Copy link
Contributor

rikatz commented May 23, 2022

@wangyysde if you can work on it, I will be happy to review :) right now I'm not working on it

@wangyysde
Copy link
Member

@rikatz ok ,then I will try to work on it.

@wangyysde
Copy link
Member

/assign

@pmint93
Copy link

pmint93 commented Jun 1, 2023

Sharding is a better approach, it also address the issue with reload becoming costly. The term "sharding" I means, there are multiple instances of Ingress Controller, each manage a subset of Ingress resources and so it have smaller configuration files, faster reload, and perhaps reduce overall memory consumption ...

But the challenge is: how to dynamically route requests to relevant instances, perhaps we need another level of dynamic routing.

@gewuang
Copy link

gewuang commented Jul 18, 2023

I'm experiencing the same problem, please ask if this issue is being looked at and if there will be any subsequent updates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests