Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing documentation reference for preserve-trailing-slash annotation #7555

Closed
fredthomsen opened this issue Aug 27, 2021 · 6 comments
Closed
Labels
kind/documentation Categorizes issue or PR as related to documentation. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@fredthomsen
Copy link
Contributor

NGINX Ingress controller version:
v1.0.0
Kubernetes version (use kubectl version):
v1.19.0
Environment:
All

What happened:

Documentation does not note the functionality implemented by #7144, nginx.ingress.kubernetes.io/preserve-trailing-slash annotation.

What you expected to happen:

A reference of this annotation in docs here: https://github.com/kubernetes/ingress-nginx/blob/main/docs/user-guide/nginx-configuration/annotations.md

#7144 has no doc updates.

How to reproduce it:

Anything else we need to know:

/kind documentation

@fredthomsen fredthomsen added the kind/bug Categorizes issue or PR as related to a bug. label Aug 27, 2021
@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority labels Aug 27, 2021
fredthomsen added a commit to Opus-Interactive/ingress-nginx that referenced this issue Aug 27, 2021
fredthomsen added a commit to Opus-Interactive/ingress-nginx that referenced this issue Aug 27, 2021
@bhumijgupta
Copy link
Member

/assign

@iamNoah1
Copy link
Contributor

/triage accepted
/remove-kind bug

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 28, 2021
@iamNoah1
Copy link
Contributor

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority labels Aug 28, 2021
@bhumijgupta
Copy link
Member

/unassign
I assume this can be closed now as the PR is merged

@iamNoah1
Copy link
Contributor

iamNoah1 commented Sep 8, 2021

/close

@k8s-ci-robot
Copy link
Contributor

@iamNoah1: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Categorizes issue or PR as related to documentation. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

4 participants