Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report if certificates are in fact expired #8045

Closed
jsoref opened this issue Dec 15, 2021 · 1 comment · Fixed by #8046
Closed

Report if certificates are in fact expired #8045

jsoref opened this issue Dec 15, 2021 · 1 comment · Fixed by #8046
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@jsoref
Copy link
Contributor

jsoref commented Dec 15, 2021

If a certificate is expired, ingress-nginx should say so

No

No

Currently, the code just says it's about to expire (no biggy):

if cert.ExpireTime.Before(time.Now().Add(240 * time.Hour)) {
klog.Warningf("SSL certificate for server %q is about to expire (%v)", host, cert.ExpireTime)

@jsoref jsoref added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 15, 2021
@k8s-ci-robot
Copy link
Contributor

@jsoref: This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority labels Dec 15, 2021
jsoref added a commit to jsoref/ingress-nginx that referenced this issue Dec 15, 2021
jsoref added a commit to jsoref/ingress-nginx that referenced this issue Dec 15, 2021
k8s-ci-robot pushed a commit that referenced this issue Dec 23, 2021
Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>
rchshld pushed a commit to joomcode/ingress-nginx that referenced this issue May 19, 2023
Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants