controllers/gce/README.md doc review

[ensonic]

https://github.com/kubernetes/ingress/blob/master/controllers/gce/README.md#the-ingress

Though glbc doesn't support HTTPS yet, security configs would also be global.

You probably want to say that it does not support https when communicating with the backends. There is a chapter on TLS termination below.

---

https://github.com/kubernetes/ingress/blob/master/controllers/gce/README.md#creation

kubectl create -f rc.yaml
replicationcontroller "glbc" created

This seems to be outdated:

kubectl create -f https://raw.githubusercontent.com/kubernetes/ingress/master/controllers/gce/rc.yaml
service "default-http-backend" created
replicationcontroller "l7-lb-controller" created

This also means that the log commadns are outdated and should be updated to e.g. kubectl logs --follow l7-lb-controller-fw4ps l7-lb-controller

Go to your GCE console and confirm that the following resources have been created through the HTTPLoadbalancing panel

There is no HTTPLoadbalancing panel, but there is this page:
https://pantheon.corp.google.com/networking/loadbalancing/loadBalancers/list

---

https://github.com/kubernetes/ingress/blob/master/controllers/gce/README.md#updates

Say you don't want a default backend ...

If you omit the default backend you seem to get some implicit default backend, which is always unhealthy - since it returns 404. Having a default that has a readyness check would be nice so that GLBC would actually use it.

---

https://github.com/kubernetes/ingress/blob/master/controllers/gce/README.md#paths

some yaml is shown as plaintext.

---

There is probably more, lets fix it iteratively.

[ensonic]

Please double check that one needs to actually deploy the
kubectl create -f https://raw.githubusercontent.com/kubernetes/ingress/master/controllers/gce/rc.yaml

In my gce installation I do have deployment in kube-system ns called 'l7-default-backend', but there is no glbc deployment. Still if I don't deploy the rc.yaml everything works (that is the ingress gets created, thje loadbalancer gets created too), except that I can't get logging for the l7-lb-controller-fw4ps and there are less errors if I run kubectl describe ing.

There is some discussion about this in kubernetes-retired/contrib#1733

[nicksardo]

Agreed that the GCE readme is a mess. It's quite verbose yet unhelpful at the same time. You're welcome to help clean it up.

You probably want to say that it does not support https when communicating with the backends. There is a chapter on TLS termination below.

Actually, front and backend HTTPS is supported. This sentence needs to be removed.

Regarding the outdated replicationcontroller and commands, would you like to tackle this in a PR?

If you omit the default backend you seem to get some implicit default backend, which is always unhealthy - since it returns 404. Having a default that has a readyness check would be nice so that GLBC would actually use it.

The default backend does not have a readinessProbe section because the ingress controller sets the default health check path to /healthz only for the default backend (specified via flag). We can add a readinessprobe section at https://github.com/kubernetes/kubernetes/blob/4a01f44b7378fb0c58450898e1bca30ea8a5158a/cluster/addons/cluster-loadbalancing/glbc/default-svc-controller.yaml.

Please double check that one needs to actually deploy the
kubectl create -f https://raw.githubusercontent.com/kubernetes/ingress/master/controllers/gce/rc.yaml

Are you running a cluster on GKE (managed K8s) or GCE (self-managed)? This question needs to dominate the readme. If users are running GKE, then the GLBC controller is already running on their master - they do not need to deploy anything. While the default-backend is visible to users, the ingress controller will not appear as it's a static pod on the master.

[ensonic]

I've started a PR here: #962

For the "replication-controller and commands" - I am running on GKE and hence I don't think there are equivalents for these commands - or is tehre are way to lok at the logs of the ingress controller? I think the logs are quite useful (e.g. to discover the SNI issue). Once we confirmed this I'll update the PR do clarify this.

Wrt to the health check:
https://github.com/kubernetes/ingress/blob/master/controllers/gce/README.md#health-checks
says one needs to reply with 200 on '/' or implement a readinessProbe. The default backend you link to configures a livenessProbe. Right now I am having trouble with a grpc backend that both defines readinessProbe and livenessProbe, but the glbc only exercises

"GET / HTTP/1.1" 404 200 "-" "GoogleHC/1.0"

and declares it unhealthy. Here again the log of the controller might be helpful.

[ensonic]

I am happy to send more PRs if you could please reply.

[bowei]

This issue was moved to kubernetes/ingress-gce#45