Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification on supported versions listed in README and relationship with nginx #9715

Closed
paba19 opened this issue Mar 11, 2023 · 3 comments
Closed
Labels
kind/documentation Categorizes issue or PR as related to documentation. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@paba19
Copy link

paba19 commented Mar 11, 2023

Hello,

while tracking various software dependencies I noticed the table for supported versions in the main README and noted that there is a column in for "Nginx Version". I noticed also, that even the most recent version of the controller lists an nginx version that seems to have gone EOL already (1.21.6).

Is it possible to clarify in the README.md what is that column for?

Does it mean that ingress-nginx is using as a dependency a version of nginx that has gone EOL? Or it means that it has been tested with a configuration that is compatible with nginx 1.21.6?

Having gone through the code it would seem like it is the case of the former, but it would be good if you could clarify in the README as well.

Also, if you confirm that ingress-nginx is indeed using nginx 1.21.6, what is the policy for bumping the nginx version? When will it be bumped?

Thanks in advance

/kind documentation
/remove-kind bug

@paba19 paba19 added the kind/bug Categorizes issue or PR as related to a bug. label Mar 11, 2023
@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. and removed kind/bug Categorizes issue or PR as related to a bug. labels Mar 11, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@strongjz
Copy link
Member

strongjz commented Mar 12, 2023

It means just that, you did point right that the version of nginx we use is here in our build script https://github.com/kubernetes/ingress-nginx/blob/main/images/nginx/rootfs/build.sh#L21

Supported is in the readme "Supported versions for the ingress-nginx project mean that we have completed E2E tests, and they are passing for the versions listed. Ingress-Nginx versions may work on older versions but the project does not make that guarantee."

The nginx base https://github.com/kubernetes/ingress-nginx/blob/main/NGINX_BASE is built with the image in https://github.com/kubernetes/ingress-nginx/tree/main/images/nginx

The nginx version itself gets updated when all the Lua modules in that same built script are supported by a new version of nginx. It takes time to build the nginx image, test all new deps, release a new base image, and update the build.

Nginx image update #9231

Base image update #9257

then release new image #9280

@balonik
Copy link
Contributor

balonik commented Nov 14, 2023

@strongjz is there any plan to update Nginx version? Last update was over a year ago. Are there any blockers to do it, because of unsupported LUA scripts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Categorizes issue or PR as related to documentation. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
Archived in project
Development

No branches or pull requests

4 participants