Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove curl dependencies in e2e tests #9716

Closed
strongjz opened this issue Mar 11, 2023 · 4 comments · Fixed by #10296 or #10306
Closed

Remove curl dependencies in e2e tests #9716

strongjz opened this issue Mar 11, 2023 · 4 comments · Fixed by #10296 or #10306
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@strongjz
Copy link
Member

In order to remove curl from our controller container, we need to remove curl dependencies in our e2e tests.

https://github.com/search?q=repo%3Akubernetes%2Fingress-nginx%20curlCmd&type=code

These tests should move the http requests to our dbg container which uses nginx for requests.

https://github.com/kubernetes/ingress-nginx/blob/main/cmd/dbg/main.go

https://github.com/kubernetes/ingress-nginx/blob/main/internal/nginx/main.go#L65

@strongjz strongjz added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 11, 2023
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Mar 11, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tao12345666333
Copy link
Member

great! +1

@github-actions
Copy link

This is stale, but we won't close it automatically, just bare in mind the maintainers may be busy with other tasks and will reach your issue ASAP. If you have any question or request to prioritize this, please reach #ingress-nginx-dev on Kubernetes Slack.

@github-actions github-actions bot added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Apr 12, 2023
@sonbui00
Copy link
Contributor

/assign

sonbui00 added a commit to sonbui00/ingress-nginx that referenced this issue Aug 11, 2023
Signed-off-by: Son Bui <sonbv00@gmail.com>
sonbui00 added a commit to sonbui00/ingress-nginx that referenced this issue Aug 11, 2023
Signed-off-by: Son Bui <sonbv00@gmail.com>
k8s-ci-robot pushed a commit that referenced this issue Aug 12, 2023
* fix: Replace curl list backend with dbg command #9716

Signed-off-by: Son Bui <sonbv00@gmail.com>

* fix: Remove curl dependencies in e2e tests #9716

Signed-off-by: Son Bui <sonbv00@gmail.com>

---------

Signed-off-by: Son Bui <sonbv00@gmail.com>
sonbui00 added a commit to sonbui00/ingress-nginx that referenced this issue Aug 12, 2023
sonbui00 added a commit to sonbui00/ingress-nginx that referenced this issue Aug 14, 2023
Signed-off-by: Son Bui <sonbv00@gmail.com>
sonbui00 added a commit to sonbui00/ingress-nginx that referenced this issue Aug 14, 2023
Signed-off-by: Son Bui <sonbv00@gmail.com>
sonbui00 added a commit to sonbui00/ingress-nginx that referenced this issue Aug 14, 2023
Signed-off-by: Son Bui <sonbv00@gmail.com>
k8s-ci-robot pushed a commit that referenced this issue Sep 8, 2023
* fix: remove curl on base container #9716

* fix: remove curl on chroot container #9716

Signed-off-by: Son Bui <sonbv00@gmail.com>

* fix: remove curl on test runner image #9716

Signed-off-by: Son Bui <sonbv00@gmail.com>

* fix: remove curl on e2e runner container #9716

Signed-off-by: Son Bui <sonbv00@gmail.com>

---------

Signed-off-by: Son Bui <sonbv00@gmail.com>
k8s-infra-cherrypick-robot pushed a commit to k8s-infra-cherrypick-robot/ingress-nginx that referenced this issue Sep 8, 2023
k8s-infra-cherrypick-robot pushed a commit to k8s-infra-cherrypick-robot/ingress-nginx that referenced this issue Sep 8, 2023
Signed-off-by: Son Bui <sonbv00@gmail.com>
k8s-infra-cherrypick-robot pushed a commit to k8s-infra-cherrypick-robot/ingress-nginx that referenced this issue Sep 8, 2023
Signed-off-by: Son Bui <sonbv00@gmail.com>
k8s-infra-cherrypick-robot pushed a commit to k8s-infra-cherrypick-robot/ingress-nginx that referenced this issue Sep 8, 2023
Signed-off-by: Son Bui <sonbv00@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
Archived in project
4 participants