-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add distroless otel init #10035
add distroless otel init #10035
Conversation
This issue is currently awaiting triage. If Ingress contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
add distroless otel init
|
||
func main() { | ||
// Enable error handling for all operations | ||
err := run() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
super nit:
I would do an if err := run(); err != nil
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, esigo, rikatz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
What this PR does / why we need it:
This PR makes the following changes to improve the init container in the project:
The transition to a distroless image enhances the security of the init container by minimizing the attack surface and reducing the number of unnecessary components.
These changes aim to enhance the efficiency, security, and overall performance of the init container.
Types of changes
Which issue/s this PR fixes
No specific issue is fixed by this PR.
How Has This Been Tested?
The init container with the distroless image has been built and deployed in a test environment.
Verification of successful pod initialization and functionality of the init container.
Manual testing to ensure that the overall build performance and image size reduction have been achieved.
Existing unit and integration tests have been executed to validate the changes.
Checklist: