Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Keep title in navbar in upcase #10755

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Docs: Keep title in navbar in upcase #10755

merged 1 commit into from
Dec 13, 2023

Conversation

pan3793
Copy link
Contributor

@pan3793 pan3793 commented Dec 13, 2023

What this PR does / why we need it:

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • CVE Report (Scanner found CVE and adding report)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation only

Which issue/s this PR fixes

N/A

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added unit and/or e2e tests to cover my changes.
  • All new and existing tests passed.

@netlify Netlify
Copy link

netlify bot commented Dec 13, 2023 •
edited
Loading

✅ Deploy Preview for kubernetes-ingress-nginx ready!

Name Link
🔨 Latest commit 55405ca
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/65794f7d0d78c60008b5ae5b
😎 Deploy Preview https://deploy-preview-10755--kubernetes-ingress-nginx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Dec 13, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: pan3793 / name: Cheng Pan (55405ca)

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 13, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @pan3793!

It looks like this is your first PR to kubernetes/ingress-nginx 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-nginx has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @pan3793. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-kind Indicates a PR lacks a `kind/foo` label and requires one. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-priority size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 13, 2023
@cpanato
Copy link
Member

cpanato commented Dec 13, 2023

Please sign the cla

@cpanato
Copy link
Member

cpanato commented Dec 13, 2023

/check-cla

@cpanato
Copy link
Member

cpanato commented Dec 13, 2023

/ok-to-test
/kind cleanup
/triage accepted
/priority backlog

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority labels Dec 13, 2023
@longwuyuan
Copy link
Contributor

@pan3793 As pointed out earlier, please sign the CLA

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 13, 2023
@pan3793
Copy link
Contributor Author

pan3793 commented Dec 13, 2023

CLA signed

@longwuyuan
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 13, 2023
cpanato
cpanato approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, longwuyuan, pan3793

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 13, 2023
@k8s-ci-robot k8s-ci-robot merged commit 6ff70f0 into kubernetes:main Dec 13, 2023
41 checks passed
@longwuyuan
Copy link
Contributor

@cpanato @pan3793 I could be totally wrong but does the effect of this PR show on your browser like do you see the G alphabet in upper case ?

@pan3793
Copy link
Contributor Author

pan3793 commented Dec 14, 2023

@longwuyuan absolutely yes

image

@longwuyuan
Copy link
Contributor

Can you show creenshot with the URL visible and also do it in a private window of the browser. I think I have some caching somwhere because I see this
image

@cpanato
Copy link
Member

cpanato commented Dec 14, 2023

interesting, in the preview i was able to see that

@longwuyuan
Copy link
Contributor

The netlify preview is good. Its on the live prod URL that I am not seeing the uppercase G, even in a private browser window. I see the code in main and I think that yaml file got the uppercase, so asking if either of you can double check and confirm that you can see the uppercase G in a private-window of your browser to at least rule out the laptop cache.

If you are seeing uppercase G in the https://kubernetes.github.io/ingress-nginx/ url, then my bad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

@tao12345666333 tao12345666333 Awaiting requested review from tao12345666333

Assignees

@longwuyuan longwuyuan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/backlog Higher priority than priority/awaiting-more-evidence. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pan3793 @k8s-ci-robot @cpanato @longwuyuan