New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for h2c communications #10918
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rsafonseca The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This issue is currently awaiting triage. If Ingress contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @rsafonseca. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
✅ Deploy Preview for kubernetes-ingress-nginx canceled.
|
/ok-to-test |
@rsafonseca what about setting the "http2 on" directive on the server block? I am fixing it right now for nginx v1.25, and IIUC this solves the problem |
You mean as opposed to setting it on the listen line? I've been working with h2c on ingress with a custom template for a while with no issues :) |
Yeah, I'm generating the image with nginx v1.25 and http2 listen directive right now :) once it is ready di you mind testing it? |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@rikatz can you post a link to the build so I can test it Monday? |
Is this no longer the case @rikatz ? #3938 (comment) |
Answering myself https://hg.nginx.org/nginx/rev/08ef02ad5c54 looks like this is now possible since nginx 1.25.1 :yay: :) |
Is this still needed with v1.10.0 upgrading to nginx 1.25 now? If not can you close it @rsafonseca |
Would be very interested in how use this feature from nginx 1.25 via ingress nginx helm chart 👏 |
What this PR does / why we need it:
This PR adds support for h2c protocol. Since it's not possible to enable http2 protocol support on port 80, and h2c is a valid protocol for a number of applications, this creates the requirements for communicating with ingresses over h2c when required (e.g. clear text GRPC)
Types of changes
Which issue/s this PR fixes
fixes #10429
fixes #10430
fixes #2444
fixes #9493
probably a bunch of others where folks stumble into problems due to GRPC not working with insecure connections
Checklist: