Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chart: Add Gacko to maintainers. Again. #11107

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Chart: Add Gacko to maintainers. Again. #11107

merged 1 commit into from
Mar 12, 2024

Conversation

Gacko
Copy link
Member

@Gacko Gacko commented Mar 12, 2024 •
edited

What this PR does / why we need it:

Initially added here, accidentally removed there. 😅

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • CVE Report (Scanner found CVE and adding report)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation only

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added unit and/or e2e tests to cover my changes.
  • All new and existing tests passed.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 12, 2024
@netlify Netlify
Copy link

netlify bot commented Mar 12, 2024 •
edited

✅ Deploy Preview for kubernetes-ingress-nginx canceled.

Name Link
🔨 Latest commit 3d4d70c
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/65f00ab8d36cdf0008cacae8

@k8s-ci-robot k8s-ci-robot added the area/helm Issues or PRs related to helm charts label Mar 12, 2024
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 12, 2024
@Gacko
Copy link
Member Author

Gacko commented Mar 12, 2024

/assign @strongjz

Since you accidentally removed me. 😉

@Gacko
Copy link
Member Author

Gacko commented Mar 12, 2024

/cherry-pick release-1.10

@k8s-infra-cherrypick-robot
Copy link
Contributor

@Gacko: once the present PR merges, I will cherry-pick it on top of release-1.10 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Gacko
Copy link
Member Author

Gacko commented Mar 12, 2024

/assign

@Gacko
Copy link
Member Author

Gacko commented Mar 12, 2024

/kind bug
/priority backlog
/triage accepted

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 12, 2024
@Gacko
Copy link
Member Author

Gacko commented Mar 12, 2024

cc @rikatz @cpanato for review. 🙂

@strongjz
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 12, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gacko, strongjz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit aa5deed into kubernetes:main Mar 12, 2024
17 checks passed
@k8s-infra-cherrypick-robot
Copy link
Contributor

@Gacko: new pull request created: #11112

In response to this:

/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Mar 12, 2024
Merged
@Gacko Gacko deleted the qxugj branch March 12, 2024 13:42
@cpanato
Copy link
Member

cpanato commented Mar 12, 2024

What happened?

@Gacko
Copy link
Member Author

Gacko commented Mar 12, 2024

I got removed from that file during releasing v1.9.6. Dunno why, probably due to the way we are forging releases and bumping stuff in the Chart.yaml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strongjz strongjz Awaiting requested review from strongjz

@ubergesundheit ubergesundheit Awaiting requested review from ubergesundheit

Assignees

@Gacko Gacko

@strongjz strongjz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/helm Issues or PRs related to helm charts cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Gacko @k8s-infra-cherrypick-robot @strongjz @k8s-ci-robot @cpanato