Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chart: Add IngressClass aliases. #11109

Merged
merged 1 commit into from Mar 17, 2024
Merged

Chart: Add IngressClass aliases. #11109

merged 1 commit into from Mar 17, 2024

Conversation

Gacko
Copy link
Member

@Gacko Gacko commented Mar 12, 2024

What this PR does / why we need it:

Adds the possibility of defining IngressClass aliases which are identical copies of the original IngressClass but with an alias as name. This can be useful for development environments with only one Ingress Controller but production-like Ingress resources.

Thanks @slimm609 for the idea and initial work here!

I'm implementing it as the original PR got stale. Also this PR is based on two other PRs (#11104, #11108) and should only be merged after them.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • CVE Report (Scanner found CVE and adding report)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation only

How Has This Been Tested?

Added unit tests.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added unit and/or e2e tests to cover my changes.
  • All new and existing tests passed.

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 12, 2024
@k8s-ci-robot k8s-ci-robot added the area/helm Issues or PRs related to helm charts label Mar 12, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 12, 2024
Copy link

netlify bot commented Mar 12, 2024

Deploy Preview for kubernetes-ingress-nginx canceled.

Name Link
🔨 Latest commit 09c31c8
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/65f46da89197bb00081c7304

@Gacko
Copy link
Member Author

Gacko commented Mar 12, 2024

/triage accepted
/kind feature
/priority backlog
/assign

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority labels Mar 12, 2024
@Gacko Gacko force-pushed the rhihg branch 2 times, most recently from 6b4e100 to 457c901 Compare March 14, 2024 13:28
@Gacko Gacko marked this pull request as ready for review March 14, 2024 13:29
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 14, 2024
@Gacko
Copy link
Member Author

Gacko commented Mar 14, 2024

/cc @rikatz @cpanato

For review. 🙂

That one's not gonna be required in v1.10.x, so no cherry-picking here.

@slimm609
Copy link

@Gacko thanks for picking this up! I had not been able to get back to it due to some work issues so thanks for running with it and pushing it over the finish line! 🥂

@Gacko
Copy link
Member Author

Gacko commented Mar 14, 2024

Hey @slimm609! Nice to hear from you. I hope the way I pointed out the original work / idea was from you is fine with you! :)

@slimm609
Copy link

Absolutely, i just ran into a timing issues with the acquisition of VMware and the ability to contribute as well as some personal issues. I reviewed and think it fits the use cases with no concerns from me

@rikatz
Copy link
Contributor

rikatz commented Mar 17, 2024

/lgtm
/approve
Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 17, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gacko, rikatz, slimm609

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 56a0968 into kubernetes:main Mar 17, 2024
17 checks passed
@Gacko Gacko deleted the rhihg branch March 18, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/helm Issues or PRs related to helm charts cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants