Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Replace deprecated grpc.Dial by grpc.NewClient. #11462

Merged
merged 1 commit into from
Jun 15, 2024

Conversation

Gacko
Copy link
Member

@Gacko Gacko commented Jun 14, 2024

What this PR does / why we need it:

grpc.Dial got deprecated in gRPC v1.64.0. We therefore need to replace it by grpc.NewClient.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • CVE Report (Scanner found CVE and adding report)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation only

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added unit and/or e2e tests to cover my changes.
  • All new and existing tests passed.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 14, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 14, 2024
Copy link

netlify bot commented Jun 14, 2024

Deploy Preview for kubernetes-ingress-nginx canceled.

Name Link
🔨 Latest commit e7a2d21
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/666c5b32627a1b00089ee6c3

@Gacko
Copy link
Member Author

Gacko commented Jun 14, 2024

/cc @cpanato @puerco

@Gacko
Copy link
Member Author

Gacko commented Jun 14, 2024

/triage accepted
/kind bug
/priority important-soon

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jun 14, 2024
@Gacko
Copy link
Member Author

Gacko commented Jun 14, 2024

/cherry-pick release-1.10

@k8s-infra-cherrypick-robot
Copy link
Contributor

@Gacko: once the present PR merges, I will cherry-pick it on top of release-1.10 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Gacko
Copy link
Member Author

Gacko commented Jun 14, 2024

/assign

@longwuyuan
Copy link
Contributor

If you are interested, you can do https://kubernetes.github.io/ingress-nginx/examples/grpc/ on your fork/clone and copy/paste all the kubectl outputs and curl outputs here and logs, to show the NewCLient method works. Not a requirement I guess though as CI passed

@longwuyuan
Copy link
Contributor

longwuyuan commented Jun 15, 2024

Or FOCUS="backend-protocol" make kind-e2e-test

@longwuyuan
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 15, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gacko, longwuyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 0718c89 into kubernetes:main Jun 15, 2024
39 checks passed
@k8s-infra-cherrypick-robot
Copy link
Contributor

@Gacko: #11462 failed to apply on top of branch "release-1.10":

Applying: Tests: Replace deprecated `grpc.Dial` by `grpc.NewClient`.
Using index info to reconstruct a base tree...
M	test/e2e/annotations/grpc.go
A	test/e2e/settings/grpc.go
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): test/e2e/settings/grpc.go deleted in HEAD and modified in Tests: Replace deprecated `grpc.Dial` by `grpc.NewClient`.. Version Tests: Replace deprecated `grpc.Dial` by `grpc.NewClient`. of test/e2e/settings/grpc.go left in tree.
Auto-merging test/e2e/annotations/grpc.go
CONFLICT (content): Merge conflict in test/e2e/annotations/grpc.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Tests: Replace deprecated `grpc.Dial` by `grpc.NewClient`.
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants