Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flags to customize listen ports and detect port collisions #1239

Merged
merged 1 commit into from
Aug 24, 2017

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Aug 24, 2017

replaces #931
fixes #56
fixes #620

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 24, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 44.327% when pulling 0459674 on aledbf:pc into b731e94 on kubernetes:master.

@aledbf aledbf merged commit e7d2ff6 into kubernetes:master Aug 24, 2017
@aledbf aledbf deleted the pc branch August 24, 2017 14:39
@aledbf aledbf added this to done in nginx 0.9-beta.12 Aug 24, 2017
@srampal
Copy link

srampal commented Aug 31, 2017

With this fix, is the functionality complete to allow arbitrary ports (not just 80, 443) to be used in the URL string ? (eg https://a.com goes to service1 and https://a.com:1000 goes to service2). Or is that still not possible even after this fix ?

@aledbf
Copy link
Member Author

aledbf commented Aug 31, 2017

@srampal no this change allows custom fixed ports to run multiple ingress controllers with different ports.

@rajasaur
Copy link

rajasaur commented Nov 4, 2017

@aledbf , to achieve what @srampal asked (having https://a.com go to SvcA and https://a.com:10000 go to SvcB), would it be possible to feed in a custom nginx.tmpl (since my requirement is just to service the same URL one at port 80 and one at port 10000, but to go to different services) as mentioned in https://github.com/kubernetes/ingress-nginx/blob/master/docs/user-guide/custom-template.md ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
No open projects
6 participants