Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom header sizes #150

Merged
merged 1 commit into from
Jan 21, 2017

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jan 20, 2017

fixes #37

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 20, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 43.305% when pulling b38afeb on aledbf:custom-header-size into fbcedc0 on kubernetes:master.

@aledbf
Copy link
Member Author

aledbf commented Jan 21, 2017

I0121 15:55:03.037908       5 nginx.go:210] --- /tmp/a682478286	2017-01-21 15:55:03.000000000 +0000
+++ /tmp/b721520085	2017-01-21 15:55:03.000000000 +0000
@@ -39,7 +39,7 @@

     keepalive_timeout 75s;

-    client_header_buffer_size       1k;
+    client_header_buffer_size       10k;
     large_client_header_buffers     4 8k;

     types_hash_max_size             2048;

@coveralls
Copy link

Coverage Status

Coverage remained the same at 43.251% when pulling 87322b8 on aledbf:custom-header-size into 30a6229 on kubernetes:master.

@aledbf aledbf merged commit d7eb3f5 into kubernetes:master Jan 21, 2017
Copy link
Member

@justinsb justinsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rikatz rikatz mentioned this pull request Jan 23, 2017
4 tasks
@aledbf aledbf deleted the custom-header-size branch February 2, 2017 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. nginx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nginx Ingress Controller ConfigMap support for header size
5 participants