Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update workloads API version extensions/v1beta1 to apps/v1 #2025

Closed
wants to merge 5 commits into from

Conversation

Davidchinacloud
Copy link

Signed-off-by: LinWengang linwengang@chinacloud.com.cn

What this PR does / why we need it: no PR

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer: update workloads API version extensions/v1beta1 to apps/v1

Signed-off-by: LinWengang <linwengang@chinacloud.com.cn>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 2, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Davidchinacloud
We suggest the following additional approver: thockin

Assign the PR to them by writing /assign @thockin in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 2, 2018
@coveralls
Copy link

coveralls commented Feb 2, 2018

Coverage Status

Coverage remained the same at 39.742% when pulling 25d164d on Davidchinacloud:dev into 2ee49d3 on kubernetes:master.

Signed-off-by: LinWengang <linwengang@chinacloud.com.cn>
LinWengang added 3 commits February 2, 2018 21:53
Signed-off-by: LinWengang <linwengang@chinacloud.com.cn>
….yaml

Signed-off-by: LinWengang <linwengang@chinacloud.com.cn>
@Davidchinacloud
Copy link
Author

/assign @aledbf PTAL

@aledbf
Copy link
Member

aledbf commented Feb 5, 2018

@Davidchinacloud we cannot merge this change because it breaks compatibility with k8s < 1.9

@Davidchinacloud
Copy link
Author

@aledbf Oh, OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants