Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates and extends client cert documentation #2104

Closed
wants to merge 3 commits into from
Closed

Updates and extends client cert documentation #2104

wants to merge 3 commits into from

Conversation

llb4ll
Copy link
Contributor

@llb4ll llb4ll commented Feb 16, 2018

Updates and extends the documentation about enabling client
certificate authentication.
Extends the provided example by updating the yaml definition
and adding setup instructions to the README.

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Updates and extends the documentation about enabling client
certificate authentication.
Extends the provided example by updating the yaml definition
and adding setup instructions to the README.
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Feb 16, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: llb4ll
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: aledbf

Assign the PR to them by writing /assign @aledbf in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 16, 2018
@llb4ll
Copy link
Contributor Author

llb4ll commented Feb 16, 2018

Second try CLA

@llb4ll
Copy link
Contributor Author

llb4ll commented Feb 16, 2018

/retest
/meow

@k8s-ci-robot
Copy link
Contributor

@llb4ll: cat image

In response to this:

/retest
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Beatrix Vad and others added 2 commits February 16, 2018 15:32
Updates and extends the documentation about enabling client
certificate authentication.
Extends the provided example by updating the yaml definition
and adding setup instructions to the README.
@llb4ll llb4ll closed this Feb 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants